Script for releasing from CI. #1562
Conversation
|
@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
880f72e to
2848551
Compare
.github/workflows/release.yml
Outdated
|
|
||
| - name: Release | ||
| run: cd cli && make publish | ||
| # env: |
There was a problem hiding this comment.
We probably going to need this 😄 (if you're commenting for testing we could also just leave the secret unset so we don't have to double merge?)
There was a problem hiding this comment.
I've left that this way so that it was guaranteed to be safe until we're ready; will definitely be adjusted prior to landing.
.github/workflows/release.yml
Outdated
| run: pnpm install --filter=turbo-monorepo | ||
|
|
||
| - name: Version | ||
| run: ./scripts/version.js ${{ inputs.increment }} ${{ inputs.identifier }} |
2848551 to
4ac285e
Compare
41d195b to
d32494c
Compare
d32494c to
5856433
Compare
5856433 to
5e5400f
Compare
ac61001 to
bb88c1e
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I have no reason to believe that this won't work, you can see two test runs: The actual publishing is the one thing I can't test until doing it live. Given that publishing is working locally on our build boxes I am very confident that it will work. |
06c7aa1 to
bb88c1e
Compare
| working-directory: cli | ||
|
|
||
| # Optional: golangci-lint command line arguments. | ||
| args: --issues-exit-code=0 |
There was a problem hiding this comment.
Why are we running this if we're continuing on errors?
There was a problem hiding this comment.
I'm using this to make sure that the installation of golangci-lint matches our normal CI setup. golangci-lint's action does not have an install-only option like GoReleaser, so I'm turning the auto-triggered run into a no-op. During make publish that also triggers linting and we do not ignore the outcome (lint failure prevents release).
| @@ -115,7 +117,7 @@ publish: clean prepublish build | |||
| cd $(CLI_DIR)/../packages/create-turbo && npm publish --tag $(TURBO_TAG) | |||
| cd $(CLI_DIR)/../packages/turbo-codemod && npm publish --tag $(TURBO_TAG) | |||
|
|
|||
| git push origin main "v$(TURBO_VERSION)" | |||
| git push -f origin main "v$(TURBO_VERSION)" | |||
There was a problem hiding this comment.
Also do you need to push up the tag?
There was a problem hiding this comment.
--forceis necessary asmainis a protected branch—that's also why there is aTURBOBOTtoken involved here. I explicitly elected against--force-with-leasebecause if we're running a release it's extremely important for the actual commit that the release is based on (hash) to be onmain. In other words: if this clobbers something else then we fix the something else, not the release.- By specifying the "v$(TURBO_VERSION)" the tag comes along for the ride.
|
Thanks for your comments, I've gone back and added commentary into the files to make sure that the information is not lost. |
Pass at clarifying documentation based upon questions in #1562.
This PR depends on #1455. After landing we would get this fun release button:
It currently, intentionally, has a commented out load of the
turbobotnpmtoken so that it's assured harmless until reviewed.