Remove cancellation workflow, fail-fast. #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
99abc18 to
13e0e6d
Compare
|
Sounds good to me. |
tknickman
approved these changes
Jun 21, 2022
| @@ -96,7 +102,7 @@ jobs: | |||
| uses: actions/setup-node@v2 | |||
| with: | |||
| node-version: 16 | |||
| cache: pnpm | |||
| cache: ${{matrix.manager}} | |||
There was a problem hiding this comment.
🙏🏼
This was getting pretty annoying yesterday, thanks for the fix!
|
Looks like the test failures might be related? They appear to be due to package-manager and caching stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A flaky test can bring down an entire set of CI runs but I only notice when I go back to look at the results, which means I've already waited for what I instinctively feel is the entire duration of the tests. Cancelled runs give me no information about the change.
Like this run here:
https://github.com/vercel/turborepo/runs/6934131393?check_suite_focus=true
I only wanted to make sure it passed Windows CI, but that got cancelled for reason of a flaky test on Linux.
This removes our cancellation workflow (replaced by built-in
concurrencygroups), and disables fast fail.It also corrects a bug in caching.