这是indexloc提供的服务,不要输入任何密码
Skip to content

Move more fields out of Config #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Move more fields out of Config #1461

merged 3 commits into from
Aug 16, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Jun 30, 2022

Commits:

  1. Move RootPackageJSON out of Config. Only run and prune need it
  2. Move calculateGlobalHash and associated code into the run package. Only run needs it, and it is unrelated to the package-dependency graph
  3. With calculateGlobalHash gone, update WithGraph to no longer need TurboJSON and Config, replaced with repoRoot.

@vercel
Copy link

vercel bot commented Jun 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Aug 16, 2022 at 5:24PM (UTC)

Base automatically changed from gsoltis/client_refactor to main June 30, 2022 18:10
@gsoltis gsoltis force-pushed the gsoltis/root_json branch from 0b2616f to 3fa6dd3 Compare June 30, 2022 18:11
@gsoltis gsoltis marked this pull request as ready for review June 30, 2022 18:11
@kodiakhq kodiakhq bot merged commit 51764ca into main Aug 16, 2022
@gsoltis
Copy link
Contributor Author

gsoltis commented Aug 16, 2022

Ugh. I forgot the on-hold label. @tknickman please still review, and I'll make any changes in a follow-up

@kodiakhq kodiakhq bot deleted the gsoltis/root_json branch August 16, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants