Set a fallback for the user's name when running turbo link #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/HFcP6LPPNAA7yfwBTFJ5Zkbn79Jc |
jaredpalmer
approved these changes
Dec 9, 2021
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
Relocate troubleshooting tip for node-canvas
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
Note that this doesn't completely close out [#54](vercel/web-tooling-internal#54) as the [tailwindcss config is optional](https://tailwindcss.com/docs/configuration). I'm digging deeper at additional ways to detect tailwind, but putting this up since it's a strict improvement. ``` olszewski@chriss-mbp next-dev % cargo run -p next-dev -- /tmp/with-tailwindcss-app Compiling next-dev v0.1.0 (/Users/olszewski/code/vercel/the-three-body/crates/next-dev) Finished dev [unoptimized + debuginfo] target(s) in 11.61s Running `/Users/olszewski/code/vercel/the-three-body/target/debug/next-dev /tmp/with-tailwindcss-app` server listening on: http://localhost:3000 error [unimplemented] /private/tmp/with-tailwindcss-app/next.config.js Feature not yet supported Handling the file `next.config.js` is currently unimplemented /private/tmp/with-tailwindcss-app/postcss.config.js Feature not yet supported Handling the file `postcss.config.js` is currently unimplemented /private/tmp/with-tailwindcss-app/tailwind.config.js Feature not yet supported Handling the file `tailwind.config.js` is currently unimplemented [200] / (3045ms) initial compilation 3468ms (3044ms task execution, 48380 tasks) updated in 874ms (8990 tasks) ```
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
) Note that this doesn't completely close out [vercel/turborepo#54](vercel/web-tooling-internal#54) as the [tailwindcss config is optional](https://tailwindcss.com/docs/configuration). I'm digging deeper at additional ways to detect tailwind, but putting this up since it's a strict improvement. ``` olszewski@chriss-mbp next-dev % cargo run -p next-dev -- /tmp/with-tailwindcss-app Compiling next-dev v0.1.0 (/Users/olszewski/code/vercel/the-three-body/crates/next-dev) Finished dev [unoptimized + debuginfo] target(s) in 11.61s Running `/Users/olszewski/code/vercel/the-three-body/target/debug/next-dev /tmp/with-tailwindcss-app` server listening on: http://localhost:3000 error [unimplemented] /private/tmp/with-tailwindcss-app/next.config.js Feature not yet supported Handling the file `next.config.js` is currently unimplemented /private/tmp/with-tailwindcss-app/postcss.config.js Feature not yet supported Handling the file `postcss.config.js` is currently unimplemented /private/tmp/with-tailwindcss-app/tailwind.config.js Feature not yet supported Handling the file `tailwind.config.js` is currently unimplemented [200] / (3045ms) initial compilation 3468ms (3044ms task execution, 48380 tasks) updated in 874ms (8990 tasks) ```
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
) Note that this doesn't completely close out [vercel/turborepo#54](vercel/web-tooling-internal#54) as the [tailwindcss config is optional](https://tailwindcss.com/docs/configuration). I'm digging deeper at additional ways to detect tailwind, but putting this up since it's a strict improvement. ``` olszewski@chriss-mbp next-dev % cargo run -p next-dev -- /tmp/with-tailwindcss-app Compiling next-dev v0.1.0 (/Users/olszewski/code/vercel/the-three-body/crates/next-dev) Finished dev [unoptimized + debuginfo] target(s) in 11.61s Running `/Users/olszewski/code/vercel/the-three-body/target/debug/next-dev /tmp/with-tailwindcss-app` server listening on: http://localhost:3000 error [unimplemented] /private/tmp/with-tailwindcss-app/next.config.js Feature not yet supported Handling the file `next.config.js` is currently unimplemented /private/tmp/with-tailwindcss-app/postcss.config.js Feature not yet supported Handling the file `postcss.config.js` is currently unimplemented /private/tmp/with-tailwindcss-app/tailwind.config.js Feature not yet supported Handling the file `tailwind.config.js` is currently unimplemented [200] / (3045ms) initial compilation 3468ms (3044ms task execution, 48380 tasks) updated in 874ms (8990 tasks) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fallback for a User's name to their username. Name is an optional field in Vercel. My user, for example, does not have a name (I don't know how or why).
This then makes it impossible to set up
turbo linkto a personal workspace.e.g.
Selecting the empty option prompts:
X Sorry, your reply was invalid: Value is requiredPost change:
