fix(create-turbo): fix ui lint in pnpm example #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
nathanhammond
previously requested changes
Jun 2, 2022
tknickman
commented
Jun 2, 2022
Comment on lines
+165
to
+166
| let sharedPkg = require(path.join(sharedTemplate, "package.json")); | ||
| let projectPkg = require(path.join(projectDir, "package.json")); |
There was a problem hiding this comment.
These were renamed for readability.
sharedPkg = the generic pacakge.json from templates/_shared_ts/package.json
projectPkg = the package manager specific package.json from templates/{packageManager}/package.json
| if (appPkg[pkgKey][key] === "*") { | ||
| appPkg[pkgKey][key] = `latest`; | ||
| // merge dependencies, giving priority to the project deps | ||
| sharedPkg[pkgKey] = { |
There was a problem hiding this comment.
Merging deps allows us to specify common dependencies in templates/_shared_ts/package.json, and package manager specific overrides in templates/{packageManager}/package.json
| @@ -194,7 +200,9 @@ async function run() { | |||
| ` - ${chalk.bold("packages/ui")}: Shared React component library` | |||
| ); | |||
| console.log( | |||
| ` - ${chalk.bold("packages/config")}: Shared configuration (ESLint)` | |||
| ` - ${chalk.bold( | |||
| "packages/eslint-config-custom" | |||
There was a problem hiding this comment.
Just updating the name here.
jaredpalmer
approved these changes
Jun 2, 2022
jaredpalmer
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues:
eslint-config-custompackage was not renamed as part of Update eslint naming in examples and addlintscript touipackage #1174Closes #1238