这是indexloc提供的服务，不要输入任何密码
Skip to content

feat(create-turbo): use basename as app name #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2022
Merged

feat(create-turbo): use basename as app name #1321

merged 3 commits into from
Jun 1, 2022

Conversation

tknickman
Copy link
Member

Closes #430.

Use last portion of path for the package.json name field.

For example:

>>> TURBOREPO

>>> Welcome to Turborepo! Let's get you set up with a new codebase.

? Where would you like to create your turborepo? ../../my-cool-repo

Will create a new turborepo at ../../my-cool-repo, and the package.json name will be: my-cool-repo;

This is similar to how create-react-app and create-next-app work.

@vercel
Copy link

vercel bot commented Jun 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
turbo-site ⬜️ Ignored (Inspect) Jun 1, 2022 at 10:28PM (UTC)

@tknickman tknickman added the pr: automerge Kodiak will merge these automatically after checks pass label Jun 1, 2022
@kodiakhq kodiakhq bot merged commit 7631fbf into main Jun 1, 2022
@kodiakhq kodiakhq bot deleted the update-create-turbo-name branch June 1, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsoltis gsoltis gsoltis approved these changes

@jaredpalmer jaredpalmer Awaiting requested review from jaredpalmer

@gaspar09 gaspar09 Awaiting requested review from gaspar09

@nathanhammond nathanhammond Awaiting requested review from nathanhammond

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make root package.json name value same as directory
2 participants
@tknickman @gsoltis