这是indexloc提供的服务,不要输入任何密码
Skip to content

Add --output option to prune command #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ersenal
Copy link

@ersenal ersenal commented May 29, 2022

This PR adds an --output option (defaults to the value out) to the prune command which can be used to specify a custom output directory.

@vercel
Copy link

vercel bot commented May 29, 2022

@ersenal is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@gsoltis
Copy link
Contributor

gsoltis commented Jun 1, 2022

@ersenal Thanks for your contribution! This bit of code, the options parsing, is actually about to get a bit of an overhaul. We're [slowly] transitioning the codebase over to use cobra for flags and commands. As part of that effort, I have a PR (#1300) in the queue that both does that port and adds a flag for the output directory. I expect that to land within the next week.

I'd love to get your confirmation that the implementation will work for you, or if there's anything else we would need to include.

@ersenal
Copy link
Author

ersenal commented Jun 2, 2022

@ersenal Thanks for your contribution! This bit of code, the options parsing, is actually about to get a bit of an overhaul. We're [slowly] transitioning the codebase over to use cobra for flags and commands. As part of that effort, I have a PR (#1300) in the queue that both does that port and adds a flag for the output directory. I expect that to land within the next week.

I'd love to get your confirmation that the implementation will work for you, or if there's anything else we would need to include.

@gsoltis Many thanks for taking a look at the PR. It looks like #1300 should cover all our needs. To add some context, as to why it'd be nice to have the option to customise the output directory, at the moment we are building a number of Docker images concurrently with pruned build contexts. Because it's not possible to change the output directory at the moment, we had to implement a synchronous build step (sequence of prunes and renaming/relocation of the out directory) before building the Docker images concurrently.

@ersenal ersenal closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants