这是indexloc提供的服务,不要输入任何密码
Skip to content

Configure Dependabot #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Conversation

nathanhammond
Copy link
Contributor

This PR configures Dependabot to monitor dependencies across all of our own packages. It does not attempt to set up Dependabot for our examples or our create-turbo templates. (I want to address that update separately.)

Note: Dependabot does not officially support pnpm (dependabot/dependabot-core#1736) and is not workspaces-friendly (dependabot/dependabot-core#4993). All Dependabot PRs for the npm ecosystem will require checking out, regenerating the lockfile, and pushing back to the branch.

I've configured checks to be monthly which seems like a decent cadence to monitor things (and cluster everything to a few hours required to shepherd everything through).

@vercel
Copy link

vercel bot commented Jun 10, 2022

@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@nathanhammond nathanhammond force-pushed the configure-dependabot branch from 1077e45 to f34fe57 Compare June 10, 2022 05:25
@vercel
Copy link

vercel bot commented Jun 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
turbo-site ⬜️ Ignored (Inspect) Jun 10, 2022 at 5:26AM (UTC)

Copy link
Contributor

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems fine, I just don't know what the implications of removing the ignore block are.

@@ -5,7 +5,31 @@ updates:
directory: '/'
schedule:
interval: 'monthly'
ignore:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe to remove? The comment seems to indicate that it's there for some reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using Husky anymore. It's nowhere to be found in our lockfile.

@samnap11
Copy link

I'm sorry if this might be bringing a new question/problem to the table. However, I would like to suggest an alternative to Dependabot for monitoring dependencies, which is Renovate. It supports pnpm, Go Modules, and also pnpm-workspace.

Hopefully, with Renovate, the process of bumping and monitoring dependencies can be performed fully by the bot.

@nathanhammond nathanhammond requested a review from gsoltis June 13, 2022 03:34
@nathanhammond
Copy link
Contributor Author

@samnap11 Thanks for the pointer! Integrating Renovate is definitely something we could consider in the future. For now this is an intentionally targeted change which addresses our existing integration with Dependabot.

@nathanhammond nathanhammond dismissed gsoltis’s stale review June 13, 2022 09:16

We're not using Husky anymore.

@kodiakhq kodiakhq bot merged commit ef54e6b into vercel:main Jun 13, 2022
@nathanhammond nathanhammond deleted the configure-dependabot branch June 14, 2022 01:34
@JoA-MoS
Copy link

JoA-MoS commented Jun 16, 2022

As an FYI: I had a similar experience but noticed some of the PR's were correct. The PR's that were correct didn't have the
in /<sub-dir> text.

ie:

chore(deps): bump commander from 9.2.0 to 9.3.0 in /my/sub-project

but PR's with just text like

chore(deps): bump commander from 9.2.0 to 9.3.0

updated all instances of commander in all of the project.json in sub-dir and the pacakge-lock.json at the root of the project

so maybe define the directory as / and don't define the individual subdirectories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants