Use git hash-object instead of git ls-files for inputs hashing #1699
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Fixes #1250 |
|
Fixes #1249 |
|
Marking as "on hold" only to prevent automerge |
mehulkar
left a comment
There was a problem hiding this comment.
Nice! I don't understand every line of Go, but I understand the gist of the work and it seems like good clean up!
| } | ||
|
|
||
| globalFileHashMap, err := fs.GetHashableDeps(rootpath, globalDepsPaths) | ||
| globalFileHashMap, err := hashing.GetHashableDeps(rootpath, globalDepsPaths) |
There was a problem hiding this comment.
Does Go have a way to import as or is it normal to infer hashing here from the imported package file name?
There was a problem hiding this comment.
It's normal to infer it, but if need be you can prefix an import with a token, like here
|
We have two more places we need to clean up that are somewhat-related, I'll pick those off.
|
As reported by @dglsparsons, after #1699 `inputs` cannot be relative from the package directory (while still remaining within the project). This issue was published in `turbo@1.4.4`. This PR patches the traversal behavior so that `inputs` works correctly and adds a test for the behavior to ensure that it does not regress.
Passing
"inputs"directly togit ls-filesusesgit's globbing, which is not the same as the rest ofturbo. Do the globbing ourselves instead, and usegit hash-object.