create-turbo: Add tests to assert package installation works #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
277ae47 to
5ad6e81
Compare
Add --runInBand to speed up CI. npm installation tests are timing out in CI, possibly becuase of lack of hardware resources. runInBand can improve performance by running tests in serial. There may also be an issue where tests are using the same directory to write node_modules and when running in parallel are erroring out. This doesn't reproduce locally, so it's possible that Jest only parallelizes in CI or non-TTY environments?
5ad6e81 to
140cf75
Compare
tknickman
approved these changes
Aug 17, 2022
| // since we are spawning a process to call turbo CLI and that can take some time | ||
| // This may be overriden in individual tests with a third param to the `it` block. E.g.: | ||
| // it('', () => {}, <override ms>) | ||
| jest.setTimeout(10_000); |
There was a problem hiding this comment.
Woah TIL about _ as a numeric separator. Cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --runInBand to speed up CI. npm installation tests are timing out
in CI, possibly becuase of lack of hardware resources. runInBand
can improve performance by running tests in serial. There may also be an
issue where tests are using the same directory to write node_modules and
when running in parallel are erroring out. This doesn't reproduce
locally, so it's possible that Jest only parallelizes in CI or non-TTY
environments?