refactor: Prune prefactor #1689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-olszewski is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
gsoltis
approved these changes
Aug 12, 2022
|
|
||
| // CanPrune returns if turbo can produce a pruned workspace. Can error if fs issues occur | ||
| func (pm PackageManager) CanPrune(projectDirectory fs.AbsolutePath) (bool, error) { | ||
| if canPrune := pm.canPrune; canPrune != nil { |
There was a problem hiding this comment.
I don't think you need canPrune here. Is this equivalent to if pm.canPrune != nil { ?
3643c2a to
1a0712e
Compare
|
Are you planning to use |
Probably not, from what I can tell |
|
(Erroneous mention.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I add support for pnpm in the prune command I wanted to add some more tests and take a quick pass at deduping some code.
--dockerflag--dockervs vanilla codepathsUnsure of the signature of
CanPruneas it could be simplified to just return an error if the package manager doesn't support, but that feels off to me. Would appreciate any thoughts on this.