output to terminal when we are just waiting for cache uploads #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
We could possibly improve the UX here with something like a progress bar or spinner |
|
Added a spinner. Here's what it looks like (only triggers after 1.5s of waiting) |
90566b8 to
707ed74
Compare
tknickman
approved these changes
Aug 15, 2022
| } | ||
|
|
||
| // WaitFor runs fn, and prints msg to the terminal if it takes longer | ||
| // than initialDay to do complete. Depending on the terminal configuration, it may |
There was a problem hiding this comment.
Suggested change
| // than initialDay to do complete. Depending on the terminal configuration, it may | |
| // than initialDelay to complete. Depending on the terminal configuration, it may |
There was a problem hiding this comment.
Kodiak beat me here - addressed in #1697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a stopgap before we move cache uploads to the daemon, I added some terminal output if uploading is blocking process completion.
While obviously not ideal that users are just waiting for cache population, I think it's at least better that they know that that is what is happening, rather than the process appearing to hang.