feat(cli): add TURBO_CI_VENDOR_ENV_KEY #1622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaredpalmer
reviewed
Aug 3, 2022
tknickman
commented
Aug 3, 2022
styfle
pushed a commit
to vercel/vercel
that referenced
this pull request
Aug 3, 2022
Set `TURBO_CI_VENDOR_ENV_KEY` to support vercel/turborepo#1622
mehulkar
approved these changes
Aug 3, 2022
| func getEnvPairsFromPrefixes(includePrefixes []string, excludePrefix string, allEnvVars map[string]string) []string { | ||
| allEnvPairs := []string{} | ||
| for _, includePrefix := range includePrefixes { | ||
| hashableFrameworkEnvPairs := getEnvPairsFromPrefix(includePrefix, excludePrefix, allEnvVars) |
There was a problem hiding this comment.
I would probably have inlined this logic, because I get confused when there are two functions named the same, but just a style preference (and I see that there were already two functions)
There was a problem hiding this comment.
This is definitely a path-dependence outcome. It'd have been fine the other way but the path we took to get here had this outcome.
There was a problem hiding this comment.
A good callout - I actually did this originally because I was going to call getEnvPairsFromPrefix in a goroutine, but decided it wasn't worth it since we're dealing with pretty small scale here.
| for k, v := range allEnvVars { | ||
| if strings.HasPrefix(k, prefix) { | ||
| hashableFrameworkEnvPairs = append(hashableFrameworkEnvPairs, fmt.Sprintf("%v=%v", k, v)) | ||
| if excludePrefix != "" && strings.HasPrefix(k, excludePrefix) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support blocklist for automatically include env vars