这是indexloc提供的服务,不要输入任何密码
Skip to content

Make releasing more-defensive of errors. #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

nathanhammond
Copy link
Contributor

@nathanhammond nathanhammond commented Aug 2, 2022

The 1.4.1 release demonstrated some gaps in the release process, this tests for error conditions before publishing, and removes the required lockfile dependency update.

@vercel
Copy link

vercel bot commented Aug 2, 2022

@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@@ -3,3 +3,5 @@ packages:
- "cli"
- "packages/*"
- "benchmark"
# Intentionally exclude the `npm` `turbo` package from the workspaces.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not "new" so-to-say. turbo only became a package very-recently, but because of how the native dependencies are generated this getting installed results in significant added complexity.

Comment on lines -107 to -110
cd $(CLI_DIR)/../scripts && ./await-publish.js
pnpm install --filter=turbo --ignore-scripts
git commit -anm "Update lockfile"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never found a method to make this work which provided actual guarantees that a second request after a successful request to the registry would return the correct information.

They appear to have an "eventually consistent" model that makes this non-viable.

@vercel
Copy link

vercel bot commented Aug 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 5:47PM (UTC)

Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the lockfile expected to be up to date already (before release) now? Why was it not this way already?

@nathanhammond
Copy link
Contributor Author

@mehulkar Actually, the way this PR configures it (removing it from the workspace), the lockfile doesn't contain the entries that were getting updated when turbo was being treated as a package.

When it's a workspace package, pnpm updates the root lockfile based upon the newly-generated release:
bfee685

@kodiakhq kodiakhq bot merged commit 4e7ed18 into vercel:main Aug 2, 2022
@nathanhammond nathanhammond deleted the more-defensive-release branch August 2, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants