-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Make releasing more-defensive of errors. #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
@@ -3,3 +3,5 @@ packages: | |||
- "cli" | |||
- "packages/*" | |||
- "benchmark" | |||
# Intentionally exclude the `npm` `turbo` package from the workspaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not "new" so-to-say. turbo
only became a package very-recently, but because of how the native dependencies are generated this getting install
ed results in significant added complexity.
cd $(CLI_DIR)/../scripts && ./await-publish.js | ||
pnpm install --filter=turbo --ignore-scripts | ||
git commit -anm "Update lockfile" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never found a method to make this work which provided actual guarantees that a second request after a successful request to the registry would return the correct information.
They appear to have an "eventually consistent" model that makes this non-viable.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the lockfile expected to be up to date already (before release) now? Why was it not this way already?
@mehulkar Actually, the way this PR configures it (removing it from the workspace), the lockfile doesn't contain the entries that were getting updated when When it's a workspace package, |
The 1.4.1 release demonstrated some gaps in the release process, this tests for error conditions before publishing, and removes the required lockfile dependency update.