docs: better gh-actions example #1197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kikobeats is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
jaredpalmer
approved these changes
May 6, 2022
|
|
||
| - name: Setup Node.js environment | ||
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 16 | ||
| cache: 'npm' |
There was a problem hiding this comment.
This is specifically the npm CI configuration, we shouldn't remove this.
| @@ -71,15 +71,25 @@ Create file called `.github/workflows/ci.yml` in your repository with the follow | |||
|
|
|||
| steps: | |||
| - name: Check out code | |||
| uses: actions/checkout@v2 | |||
| uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
This is unrelated but if we're going to make this switch let's get all of the locations.
| with: | ||
| fetch-depth: 2 | ||
| path: | | ||
| node_modules/.cache/turbo |
There was a problem hiding this comment.
This will grow unboundedly as turbo does not presently prune caches and it will use the alternative restore-keys to always end up with a hit.
| fetch-depth: 2 | ||
| path: | | ||
| node_modules/.cache/turbo | ||
| # if you use pnpm, uncomment the following lines |
There was a problem hiding this comment.
The pnpm stuff should be dropped into the pnpm configuration later in this file.
| # ~/.pnpm-store | ||
| key: ${{ runner.os }}-${{ matrix.os }}-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-${{ matrix.os }}- |
There was a problem hiding this comment.
runner.os and matrix.os are redundant here.
nathanhammond
added a commit
that referenced
this pull request
May 11, 2022
This reverts commit 5b1afb1.
jaredpalmer
pushed a commit
that referenced
this pull request
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I updated the GitHub Actions example to maximize caching capabilities.