这是indexloc提供的服务，不要输入任何密码
Skip to content

Address all SSA-dependent lint. #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2022
Merged

Address all SSA-dependent lint. #1181

merged 1 commit into from
May 4, 2022

Conversation

nathanhammond
Copy link
Contributor

@nathanhammond nathanhammond commented May 4, 2022 •
edited
Loading

Go has numerous linters which are dependent upon x/tools/go/ssa which has not yet been updated to support generics (golang/go#48525).

This PR addresses all of the lint detected in our codebase via linters which depend on SSA analysis.

internal/cache/cache_signature_authentication.go:102:6: type `readCloser` is unused (unused)
internal/cache/cache_signature_authentication.go:78:45: func `(*ArtifactSignatureAuthentication).streamValidator` is unused (unused)
internal/fs/package_deps_hash.go:169:2: S1011: should replace loop with `cmd.Args = append(cmd.Args, patterns...)` (gosimple)
internal/fs/package_deps_hash.go:225:8: S1009: should omit nil check; len() for nil slices is defined as zero (gosimple)
internal/run/run.go:310:5: S1038: should use fmt.Fprintf instead of fmt.Fprintln(fmt.Sprintf(...)) (but don't forget the newline) (gosimple)
internal/run/run.go:917:2: S1021: should merge variable declaration with assignment on next line (gosimple)

@vercel
Copy link

vercel bot commented May 4, 2022

@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented May 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview May 4, 2022 at 0:49AM (UTC)

@jaredpalmer jaredpalmer merged commit dbace79 into vercel:main May 4, 2022
@nathanhammond nathanhammond deleted the ssa-dependent-lint branch May 4, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsoltis gsoltis gsoltis approved these changes

@jaredpalmer jaredpalmer Awaiting requested review from jaredpalmer

@gaspar09 gaspar09 Awaiting requested review from gaspar09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanhammond @gsoltis @jaredpalmer