这是indexloc提供的服务,不要输入任何密码
Skip to content

Remove unused golint. #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2022
Merged

Remove unused golint. #1170

merged 3 commits into from
May 4, 2022

Conversation

nathanhammond
Copy link
Contributor

Removing golint is a no-op. This change removes a warning from our lint runs telling us to use revive (which we do), so it has no other material change to the run output.

@vercel
Copy link

vercel bot commented May 3, 2022

@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented May 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview May 4, 2022 at 4:17AM (UTC)

@nathanhammond
Copy link
Contributor Author

nathanhammond commented May 4, 2022

@gsoltis This is 1:1, safe to remove golint. Confirmed via documentation: https://github.com/mgechev/revive/blob/master/README.md?plain=1#L190

And it also matches my test runs which demonstrated no differences.

Copy link
Contributor

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for checking

@jaredpalmer jaredpalmer merged commit 6981a50 into vercel:main May 4, 2022
@nathanhammond nathanhammond deleted the remove-golint branch May 4, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants