这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(config-dir): Resolve relative TURBO_CONFIG_DIR_PATH before validation #11122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2025
+29 −4
Merged

fix(config-dir): Resolve relative TURBO_CONFIG_DIR_PATH before validation #11122

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90006fc
fix: resolve TURBO_CONFIG_DIR_PATH to absolute path
praggCode Nov 15, 2025
1476ed5
Merge branch 'main' into fix-absolute-config-path
anthonyshew Nov 18, 2025
3d78934
Handle empty env var being set.
anthonyshew Nov 18, 2025
ee9c21e
clippy
anthonyshew Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions crates/turborepo-dirs/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,23 @@ use turbopath::{AbsoluteSystemPathBuf, PathError};
/// is set, it will return that path instead of `dirs_next::config_dir`.
pub fn config_dir() -> Result<Option<AbsoluteSystemPathBuf>, PathError> {
if let Ok(dir) = std::env::var("TURBO_CONFIG_DIR_PATH") {
return AbsoluteSystemPathBuf::new(dir).map(Some);
// Reject empty strings per Unix convention
if dir.is_empty() {
return Err(PathError::InvalidUnicode(dir));
}

let raw = std::path::PathBuf::from(&dir);

// Resolve to absolute path if necessary
let abs = if raw.is_absolute() {
raw
} else {
std::env::current_dir()?.join(raw)
};

let abs_str = abs.to_str().ok_or(PathError::InvalidUnicode(dir))?;

return AbsoluteSystemPathBuf::new(abs_str).map(Some);
}

dirs_config_dir()
Expand All @@ -28,6 +44,11 @@ pub fn config_dir() -> Result<Option<AbsoluteSystemPathBuf>, PathError> {
/// is set, it will return that path instead of `dirs_next::config_dir`.
pub fn vercel_config_dir() -> Result<Option<AbsoluteSystemPathBuf>, PathError> {
if let Ok(dir) = std::env::var("VERCEL_CONFIG_DIR_PATH") {
// Reject empty strings per Unix convention.
if dir.is_empty() {
return Err(PathError::InvalidUnicode(dir));
}

return AbsoluteSystemPathBuf::new(dir).map(Some);
}

Expand Down Expand Up @@ -73,14 +94,18 @@ mod tests {
}

#[test]
fn test_config_dir_with_invalid_env_var() {
// Set TURBO_CONFIG_DIR_PATH to a relative path (invalid)
fn test_config_dir_with_relative_path() {
// Set TURBO_CONFIG_DIR_PATH to a relative path (should be resolved to absolute)
unsafe {
env::set_var("TURBO_CONFIG_DIR_PATH", "relative/path");
}

let result = config_dir();
assert!(result.is_err());
assert!(result.is_ok());
let path = result.unwrap();
assert!(path.is_some());
// Verify it was resolved to an absolute path
assert!(path.unwrap().as_path().is_absolute());

unsafe {
env::remove_var("TURBO_CONFIG_DIR_PATH");
Expand Down
Loading