这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Nov 7, 2025

Description

Make CLI builds faster. If you ever need them, the values can be adjusted on your branch.

Testing Instructions

CI

@vercel
Copy link
Contributor

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
examples-basic-web Ready Ready Preview Comment Nov 7, 2025 8:08pm
examples-designsystem-docs Ready Ready Preview Comment Nov 7, 2025 8:08pm
examples-gatsby-web Ready Ready Preview Comment Nov 7, 2025 8:08pm
examples-kitchensink-blog Ready Ready Preview Comment Nov 7, 2025 8:08pm
examples-nonmonorepo Ready Ready Preview Comment Nov 7, 2025 8:08pm
examples-svelte-web Ready Ready Preview Comment Nov 7, 2025 8:08pm
examples-tailwind-web Ready Ready Preview Comment Nov 7, 2025 8:08pm
examples-vite-web Ready Ready Preview Comment Nov 7, 2025 8:08pm
turbo-site Ready Ready Preview Comment Nov 7, 2025 8:08pm

Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

The condition checking for Windows runner will fail to match after changing the runner from windows-latest to windows-latest-8-cores, causing the crlf configuration step to be skipped on Windows.

View Details
📝 Patch Details
diff --git a/.github/workflows/turborepo-test.yml b/.github/workflows/turborepo-test.yml
index b219d275e..653ad65b8 100644
--- a/.github/workflows/turborepo-test.yml
+++ b/.github/workflows/turborepo-test.yml
@@ -125,7 +125,7 @@ jobs:
       # the line endings on checkout, the file hashes will change.
       # https://www.git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#_core_autocrlf
       - name: set crlf
-        if: matrix.os.runner == 'windows-latest'
+        if: startsWith(matrix.os.runner, 'windows')
         shell: bash
         run: git config --global core.autocrlf input
       - uses: actions/checkout@v4

Analysis

Windows runner condition mismatch prevents CRLF configuration

What fails: The "set crlf" step in the integration workflow never executes on Windows runners after the runner was updated to windows-latest-8-cores, because the condition still checks for the old runner name windows-latest.

How to reproduce:

  1. The matrix defines windows-latest-8-cores as the Windows runner (line 119)
  2. The "set crlf" step condition checks if: matrix.os.runner == 'windows-latest' (line 128)
  3. When the workflow runs on Windows, matrix.os.runner evaluates to windows-latest-8-cores
  4. The condition 'windows-latest-8-cores' == 'windows-latest' evaluates to false
  5. The step is skipped

Result: Git's autocrlf setting is never configured on Windows, causing line endings in test fixtures to be converted to CRLF on checkout, which changes file hashes and breaks test stability.

Expected: The step should execute on all Windows runner variants. According to the comment above the step, this configuration is critical: "we want this because this repo also contains the fixtures for our test cases and these fixtures have files that need stable file hashes. If we let git update the line endings on checkout, the file hashes will change."

Fix: Changed the condition from if: matrix.os.runner == 'windows-latest' to if: startsWith(matrix.os.runner, 'windows') to match any Windows runner variant, consistent with GitHub Actions practices.

Fix on Vercel

@anthonyshew anthonyshew marked this pull request as ready for review November 7, 2025 19:59
@anthonyshew anthonyshew requested a review from a team as a code owner November 7, 2025 19:59
@anthonyshew anthonyshew requested a review from tknickman November 7, 2025 19:59
@anthonyshew anthonyshew changed the title ci: try lowering opt-level ci: Lower opt-level for dev builds Nov 7, 2025
@anthonyshew anthonyshew changed the title ci: Lower opt-level for dev builds ci: Lower opt-level and remove debug symbols for dev builds Nov 7, 2025
@anthonyshew anthonyshew changed the title ci: Lower opt-level and remove debug symbols for dev builds ci: Lower opt-level and remove debug symbols for dev profile Nov 7, 2025
@anthonyshew anthonyshew merged commit 03895cd into main Nov 7, 2025
42 checks passed
@anthonyshew anthonyshew deleted the shew/e5aa6 branch November 7, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants