-
Notifications
You must be signed in to change notification settings - Fork 2.1k
ci: Lower opt-level and remove debug symbols for dev profile #11068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Suggestion:
The condition checking for Windows runner will fail to match after changing the runner from windows-latest to windows-latest-8-cores, causing the crlf configuration step to be skipped on Windows.
View Details
📝 Patch Details
diff --git a/.github/workflows/turborepo-test.yml b/.github/workflows/turborepo-test.yml
index b219d275e..653ad65b8 100644
--- a/.github/workflows/turborepo-test.yml
+++ b/.github/workflows/turborepo-test.yml
@@ -125,7 +125,7 @@ jobs:
# the line endings on checkout, the file hashes will change.
# https://www.git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#_core_autocrlf
- name: set crlf
- if: matrix.os.runner == 'windows-latest'
+ if: startsWith(matrix.os.runner, 'windows')
shell: bash
run: git config --global core.autocrlf input
- uses: actions/checkout@v4
Analysis
Windows runner condition mismatch prevents CRLF configuration
What fails: The "set crlf" step in the integration workflow never executes on Windows runners after the runner was updated to windows-latest-8-cores, because the condition still checks for the old runner name windows-latest.
How to reproduce:
- The matrix defines
windows-latest-8-coresas the Windows runner (line 119) - The "set crlf" step condition checks
if: matrix.os.runner == 'windows-latest'(line 128) - When the workflow runs on Windows,
matrix.os.runnerevaluates towindows-latest-8-cores - The condition
'windows-latest-8-cores' == 'windows-latest'evaluates to false - The step is skipped
Result: Git's autocrlf setting is never configured on Windows, causing line endings in test fixtures to be converted to CRLF on checkout, which changes file hashes and breaks test stability.
Expected: The step should execute on all Windows runner variants. According to the comment above the step, this configuration is critical: "we want this because this repo also contains the fixtures for our test cases and these fixtures have files that need stable file hashes. If we let git update the line endings on checkout, the file hashes will change."
Fix: Changed the condition from if: matrix.os.runner == 'windows-latest' to if: startsWith(matrix.os.runner, 'windows') to match any Windows runner variant, consistent with GitHub Actions practices.
Description
Make CLI builds faster. If you ever need them, the values can be adjusted on your branch.
Testing Instructions
CI