fix(boundaries): Enable import attributes parsing #11053
Merged
+15
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables parsing of import attributes (the `with` keyword syntax) in the boundaries command by setting `import_attributes: true` in the SWC parser configuration. This was previously fixed for turbo-trace in PR #10078 but was missing from the boundaries module, causing parse errors when encountering syntax like `import x from 'y' with { type: 'json' }`. Fixes #10961 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Updates the test file to match the actual output from the boundaries command: - Adjusts patching file order pattern to handle all three files (import-attributes.js, index.ts, types.ts) - Adds glob patterns to handle trailing whitespace differences - Fixes blank line expectations in git diff output 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Merging past known CI flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10961 - Enables parsing of import attributes (the
withkeyword syntax) in theturbo boundariescommand.Details
The issue was that PR #10078 fixed import attributes parsing for
turbo-tracebut didn't apply the same fix to the boundaries module. This caused the boundaries command to fail with "Expected ';', got 'with'" when encountering modern import syntax like:Changes
import_attributes: trueto the SWC ES syntax configuration incrates/turborepo-lib/src/boundaries/mod.rs:437Test Plan
🤖 Generated with Claude Code