这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Gabrola
Copy link
Contributor

@Gabrola Gabrola commented Oct 31, 2025

bunfig.toml is basically bun's .npmrc file. Needs to be copied to handle options like linker = hoisted

Prune was already correctly pruning the patchedDepenedencies in the lockfile for bun, but it wasn't pruning them from package.json which was causing bun install to complain that the patches were missing.

In addition, it was not copying the patch files for packages that weren't pruned

@Gabrola Gabrola requested a review from a team as a code owner October 31, 2025 02:41
@Gabrola Gabrola requested a review from tknickman October 31, 2025 02:41
@vercel
Copy link
Contributor

vercel bot commented Oct 31, 2025

@Gabrola is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@anthonyshew
Copy link
Contributor

Hey, @Gabrola, appreciate you making a PR!

My feedback here is to make sure we solve one problem at a time. I reproduced the issue with patches that you've mentioned, and think we should focus on that for this PR. I built the binary from this code and it looks like it fixes the issue.

Can you remove the bunfig.toml handling from this PR, and then we can merge? You can follow up with a separate PR for handling bunfig.toml, if you'd like.

@Gabrola
Copy link
Contributor Author

Gabrola commented Nov 5, 2025

Hi @anthonyshew, thank you for the review! Sure, that makes sense, I've dropped the bunfig.toml commit

@Gabrola Gabrola force-pushed the youssef/bun-prune-fixes branch from 1754e3c to 884a163 Compare November 5, 2025 10:22
@Gabrola Gabrola changed the title fix(prune): handle patchedDependencies for bun and copy bunfig.toml fix(prune): handle patchedDependencies for bun Nov 5, 2025
@anthonyshew anthonyshew changed the title fix(prune): handle patchedDependencies for bun fix(prune): Handle patchedDependencies for bun Nov 5, 2025
@vercel
Copy link
Contributor

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
examples-basic-web Ready Ready Preview Comment Nov 5, 2025 3:51pm
examples-designsystem-docs Ready Ready Preview Comment Nov 5, 2025 3:51pm
examples-gatsby-web Ready Ready Preview Comment Nov 5, 2025 3:51pm
examples-kitchensink-blog Ready Ready Preview Comment Nov 5, 2025 3:51pm
examples-nonmonorepo Ready Ready Preview Comment Nov 5, 2025 3:51pm
examples-svelte-web Ready Ready Preview Comment Nov 5, 2025 3:51pm
examples-tailwind-web Ready Ready Preview Comment Nov 5, 2025 3:51pm
examples-vite-web Ready Ready Preview Comment Nov 5, 2025 3:51pm
turbo-site Ready Ready Preview Comment Nov 5, 2025 3:51pm

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthonyshew anthonyshew enabled auto-merge (squash) November 5, 2025 16:09
@anthonyshew anthonyshew disabled auto-merge November 5, 2025 16:22
@anthonyshew
Copy link
Contributor

Ubuntu integration tests are hanging for some reason. I've tested manually and the tests are passing. Will look into this, but merging past the issue for now.

@anthonyshew anthonyshew merged commit 4e852e1 into vercel:main Nov 5, 2025
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants