-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(prune): Handle patchedDependencies for bun
#11027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Gabrola is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey, @Gabrola, appreciate you making a PR! My feedback here is to make sure we solve one problem at a time. I reproduced the issue with patches that you've mentioned, and think we should focus on that for this PR. I built the binary from this code and it looks like it fixes the issue. Can you remove the |
|
Hi @anthonyshew, thank you for the review! Sure, that makes sense, I've dropped the |
1754e3c to
884a163
Compare
patchedDependencies for bun and copy bunfig.tomlpatchedDependencies for bun
patchedDependencies for bunpatchedDependencies for bun
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…turborepo into youssef/bun-prune-fixes
anthonyshew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…turborepo into youssef/bun-prune-fixes
|
Ubuntu integration tests are hanging for some reason. I've tested manually and the tests are passing. Will look into this, but merging past the issue for now. |
bunfig.tomlis basically bun's.npmrcfile. Needs to be copied to handle options likelinker = hoistedPrune was already correctly pruning the
patchedDepenedenciesin the lockfile for bun, but it wasn't pruning them frompackage.jsonwhich was causingbun installto complain that the patches were missing.In addition, it was not copying the patch files for packages that weren't pruned