这是indexloc提供的服务，不要输入任何密码
Skip to content

chore(with-docker/Dockerfile): Some improvements #11010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2025
Merged

chore(with-docker/Dockerfile): Some improvements #11010

merged 3 commits into from
Nov 5, 2025

Conversation

@yairopro
Copy link
Contributor

@yairopro yairopro commented Oct 24, 2025 •
edited
Loading

Description

I (think I) improved the Dockerfile of the web in the example "with-docker".

  1. The "base" image install libc6-compat once only
  2. The "base" image set the workspace to /app once only
  3. The "builder" image, which was doing the prune is renamed to "initiator" because, you know, it doesn't build the app...
  4. The "installer" image, which was doing the build is renamed to "builder" because, you know, it builds the app...
  5. A deprecated comment (I think) has been removed. But correct me, I am probably wrong

Testing Instructions

docker build -f apps/web/Dockerfile -t "awesome" .

@yairopro yairopro requested a review from a team as a code owner October 24, 2025 06:01
@yairopro yairopro requested a review from tknickman October 24, 2025 06:01
@turbo-orchestrator turbo-orchestrator bot added the area: examples Improvements or additions to examples label Oct 24, 2025
@vercel
Copy link
Contributor

vercel bot commented Oct 24, 2025

@yairopro is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@yairopro yairopro force-pushed the chore/with-docker-dockerfile-edit branch from 8b77d9f to 99d4881 Compare October 24, 2025 06:06
@yairopro yairopro changed the title chore(with-docker/Dockerfile): some improvements chore(with-docker/Dockerfile): Some improvements Oct 29, 2025
@anthonyshew anthonyshew self-requested a review as a code owner November 5, 2025 06:28
@turbo-orchestrator turbo-orchestrator bot added the area: docs Improvements or additions to documentation label Nov 5, 2025
anthonyshew
anthonyshew approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vercel
Copy link
Contributor

vercel bot commented Nov 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
turbo-site Ready Ready Preview Comment Nov 5, 2025 6:31am

@anthonyshew anthonyshew merged commit b97cecf into vercel:main Nov 5, 2025
5 of 13 checks passed
@yairopro
Copy link
Contributor Author

yairopro commented Nov 5, 2025

@anthonyshew Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

Assignees

No one assigned

Labels

area: docs Improvements or additions to documentation area: examples Improvements or additions to examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yairopro @anthonyshew