Refactor turbo_json #1152
Merged
Refactor turbo_json #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3bda6a9 to
d0d5c03
Compare
gsoltis
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparing to hide some package manager details I discovered this code was unnecessarily coupled to
package_json, and in multiple places in the codebase.Split commits to make it easier to follow:
package_jsoninto two pieces.config.goto its new home.turboConfigwhich has a confusable inTurborepoConfigfrom the login work.A pretty-obvious bit of followup work is to move both
package_jsonandturbo_jsonout of thefspackage—they could be trivially refactored to never touch the file system (and possibly should be for testability reasons).