Remove test directories from workspace ignores. #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These directories aren't excluded by default in any package manager. We should aim to match the behavior of the upstream package managers even if this may result in a quality of life improvement for some users.
Contributor
|
@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
@jaredpalmer You introduced this in #310, I'm not sure if this is still required, or what pain point this was attempting to address. (612c539) |
6 tasks
jaredpalmer
approved these changes
Apr 29, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
May 11, 2022
…1187) This change moves all of the information collection about the package manager into the package manager object itself. This is the more-correct solution to #1143, improving upon the already-landed #1145. It does not yet address the issue reported in #998, but lays the groundwork to address it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These directories aren't excluded by default in any package manager. We should aim to match the behavior of the upstream package managers even if this may result in a quality of life improvement for some users.
This is an incomplete fix, but I believe that addressing a compatibility issue is more-important than trying to deliver the complete fix.
Closes #1143