这是indexloc提供的服务，不要输入任何密码
Skip to content

chore(deps): bump react-dom and @types/react-dom in /examples/non-monorepo #10903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(deps): bump react-dom and @types/react-dom in /examples/non-monorepo #10903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/non-monorepo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
"dependencies": {
"next": "15.4.6",
"react": "^19.1.0",
"react-dom": "^19.1.0",
"react-dom": "^19.1.1",
Copy link
Contributor

@vercel vercel bot Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json was updated to require react-dom@^19.1.1 and @types/react-dom@^19.1.9, but the corresponding pnpm-lock.yaml lockfile was not updated and still references the old versions (19.1.0 and 19.1.6 respectively).

View Details
📝 Patch Details 
diff --git a/examples/non-monorepo/pnpm-lock.yaml b/examples/non-monorepo/pnpm-lock.yaml
index 6eb26b874..c830a86b6 100644
--- a/examples/non-monorepo/pnpm-lock.yaml
+++ b/examples/non-monorepo/pnpm-lock.yaml
@@ -7,13 +7,13 @@ settings:
 dependencies:
   next:
     specifier: 15.4.6
-    version: 15.4.6(react-dom@19.1.0)(react@19.1.0)
+    version: 15.4.6(react-dom@19.1.1)(react@19.1.0)
   react:
     specifier: ^19.1.0
     version: 19.1.0
   react-dom:
-    specifier: ^19.1.0
-    version: 19.1.0(react@19.1.0)
+    specifier: ^19.1.1
+    version: 19.1.1(react@19.1.0)
   turbo:
     specifier: ^2.5.4
     version: 2.5.4
@@ -29,8 +29,8 @@ devDependencies:
     specifier: ^19.1.6
     version: 19.1.8
   '@types/react-dom':
-    specifier: ^19.1.6
-    version: 19.1.6(@types/react@19.1.8)
+    specifier: ^19.1.9
+    version: 19.1.9(@types/react@19.1.8)
   eslint:
     specifier: ^9.33.0
     version: 9.33.0
@@ -534,8 +534,8 @@ packages:
       undici-types: 6.21.0
     dev: true
 
-  /@types/react-dom@19.1.6(@types/react@19.1.8):
-    resolution: {integrity: sha512-4hOiT/dwO8Ko0gV1m/TJZYk3y0KBnY9vzDh7W+DH17b2HFSOGgdj33dhihPeuy3l0q23+4e+hoXHV6hCC4dCXw==}
+  /@types/react-dom@19.1.9(@types/react@19.1.8):
+    resolution: {integrity: sha512-qXRuZaOsAdXKFyOhRBg6Lqqc0yay13vN7KrIg4L7N4aaHN68ma9OK3NE1BoDFgFOTfM7zg+3/8+2n8rLUH3OKQ==}
     peerDependencies:
       '@types/react': ^19.0.0
     dependencies:
@@ -2252,7 +2252,7 @@ packages:
     resolution: {integrity: sha512-OWND8ei3VtNC9h7V60qff3SVobHr996CTwgxubgyQYEpg290h9J0buyECNNJexkFm5sOajh5G116RYA1c8ZMSw==}
     dev: true
 
-  /next@15.4.6(react-dom@19.1.0)(react@19.1.0):
+  /next@15.4.6(react-dom@19.1.1)(react@19.1.0):
     resolution: {integrity: sha512-us++E/Q80/8+UekzB3SAGs71AlLDsadpFMXVNM/uQ0BMwsh9m3mr0UNQIfjKed8vpWXsASe+Qifrnu1oLIcKEQ==}
     engines: {node: ^18.18.0 || ^19.8.0 || >= 20.0.0}
     hasBin: true
@@ -2278,7 +2278,7 @@ packages:
       caniuse-lite: 1.0.30001723
       postcss: 8.4.31
       react: 19.1.0
-      react-dom: 19.1.0(react@19.1.0)
+      react-dom: 19.1.1(react@19.1.0)
       styled-jsx: 5.1.6(react@19.1.0)
     optionalDependencies:
       '@next/swc-darwin-arm64': 15.4.6
@@ -2467,10 +2467,10 @@ packages:
     resolution: {integrity: sha512-NuaNSa6flKT5JaSYQzJok04JzTL1CA6aGhv5rfLW3PgqA+M2ChpZQnAC8h8i4ZFkBS8X5RqkDBHA7r4hej3K9A==}
     dev: true
 
-  /react-dom@19.1.0(react@19.1.0):
-    resolution: {integrity: sha512-Xs1hdnE+DyKgeHJeJznQmYMIBG3TKIHJJT95Q58nHLSrElKlGQqDTR2HQ9fx5CN/Gk6Vh/kupBTDLU11/nDk/g==}
+  /react-dom@19.1.1(react@19.1.0):
+    resolution: {integrity: sha512-Dlq/5LAZgF0Gaz6yiqZCf6VCcZs1ghAJyrsu84Q/GT0gV+mCxbfmKNoGRKBYMJ8IEdGPqu49YWXD02GCknEDkw==}
     peerDependencies:
-      react: ^19.1.0
+      react: ^19.1.1
     dependencies:
       react: 19.1.0
       scheduler: 0.26.0

Analysis

Outdated pnpm lockfile in examples/non-monorepo

What fails: The pnpm-lock.yaml file in examples/non-monorepo/ has outdated specifiers and versions for react-dom (^19.1.0 → ^19.1.1) and @types/react-dom (^19.1.6 → ^19.1.9) that don't match the updated package.json.

How to reproduce:

cd examples/non-monorepo
# Check semver compatibility
node -e "const semver = require('semver'); console.log('19.1.0 satisfies ^19.1.1:', semver.satisfies('19.1.0', '^19.1.1'));"
# Returns: false

# Install with workspace isolation
pnpm install --ignore-workspace

Result: pnpm installs the updated versions (react-dom@19.1.1 and @types/react-dom@19.1.9) because the lockfile specifiers don't match package.json requirements. The lockfile is regenerated with the correct specifiers.

Expected: Lockfile should have been updated when package.json dependencies were changed. The version 19.1.0 doesn't satisfy the semver range ^19.1.1, creating an inconsistency between package.json and pnpm-lock.yaml.

Fix: Ran pnpm install --ignore-workspace in examples/non-monorepo/ to regenerate the lockfile with correct specifiers and versions matching the package.json requirements.

"turbo": "^2.5.4"
},
"devDependencies": {
"@eslint/eslintrc": "^3.3.1",
"@types/node": "^22.15.30",
"@types/react": "^19.1.6",
"@types/react-dom": "^19.1.6",
"@types/react-dom": "^19.1.9",
"eslint": "^9.33.0",
"eslint-config-next": "15.4.2",
"typescript": "^5.9.2"
Expand Down
Loading