这是indexloc提供的服务,不要输入任何密码
Skip to content

Housekeeping on "link" before Remote-Caching-Enabled work #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 25, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Apr 19, 2022

In this PR:

  • Port turbo link to cobra
  • Add a helper for use during the transition to cobra to get help text from a command
  • Abstract out the survey pieces
  • Add some helpers to client.ApiClient (I think we can un-export Token now)

Once we have a filesystem abstraction, link should be testable. As it is, it writes to the user's home directory and the repo's directory (technically cwd for the process).

@vercel
Copy link

vercel bot commented Apr 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Apr 25, 2022 at 9:32PM (UTC)

Copy link
Contributor

@nathanhammond nathanhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a comment because I don't Go.

err := survey.AskOne(
&survey.Select{
Message: "Which Vercel scope (and Remote Cache) do you want associate with this Turborepo? ",
Options: teams,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

survey supports pagination, ApiClient supports pagination, we should remember to go back and add the ability to request more.

@kodiakhq kodiakhq bot merged commit b00b258 into main Apr 25, 2022
@gsoltis gsoltis deleted the gsoltis/link_prework branch April 28, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants