这是indexloc提供的服务，不要输入任何密码
Skip to content

ci: checks for eslint-config-turbo interface #10794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 25, 2025
Merged

ci: checks for eslint-config-turbo interface #10794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
555e1bc
ci: checks for our JavaScript package interfaces
anthonyshew Aug 25, 2025
e26428f
WIP 0ed9a
anthonyshew Aug 25, 2025
b8abd6b
WIP 3fa5c
anthonyshew Aug 25, 2025
c04c73e
WIP 30cd3
anthonyshew Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-js-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
# to run when turbo core changes. This job (`js_packages`) does not run on turborpeo core
# changes, and we don't want to enable that beahvior for _all_ our JS packages.
run: |
TURBO_API= turbo run check-types test build --filter="!turborepo-repository" --filter={./packages/*}...[${{ github.event.pull_request.base.sha || 'HEAD^1' }}] --color --env-mode=strict
TURBO_API= turbo run check-types test build package-checks --filter="!turborepo-repository" --filter={./packages/*}...[${{ github.event.pull_request.base.sha || 'HEAD^1' }}] --color --env-mode=strict
env:
NODE_VERSION: ${{ matrix.node-version }}

Expand Down
27 changes: 16 additions & 11 deletions packages/eslint-config-turbo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
{
"name": "eslint-config-turbo",
"version": "2.5.6",
"type": "commonjs",
"description": "ESLint config for Turborepo",
"license": "MIT",
"author": "Vercel",
"repository": {
"type": "git",
"url": "https://github.com/vercel/turborepo",
"url": "git+https://github.com/vercel/turborepo.git",
"directory": "packages/eslint-config-turbo"
},
"bugs": {
Expand All @@ -13,7 +16,9 @@
"scripts": {
"build": "bunchee",
"lint": "eslint src",
"lint:prettier": "prettier -c . --cache --ignore-path=../../.prettierignore"
"lint:prettier": "prettier -c . --cache --ignore-path=../../.prettierignore",
"package:lint": "publint --strict",
"package:types": "attw --profile node16 --pack"
},
"keywords": [
"turbo",
Expand All @@ -22,7 +27,12 @@
"eslintconfig",
"eslint-config"
],
"files": [
"dist"
],
"main": "./dist/cjs/index.js",
"types": "./dist/cjs/index.d.ts",
"module": "./dist/es/index.mjs",
"exports": {
"./flat": {
"import": {
Expand All @@ -45,25 +55,20 @@
}
}
},
"author": "Vercel",
"dependencies": {
"eslint-plugin-turbo": "workspace:*"
},
"peerDependencies": {
"eslint": ">6.6.0",
"turbo": ">2.0.0"
},
"license": "MIT",
"devDependencies": {
"@arethetypeswrong/cli": "^0.18.2",
"@turbo/eslint-config": "workspace:*",
"@turbo/tsconfig": "workspace:*",
"@types/eslint": "^8.56.10",
"@types/node": "^20",
"bunchee": "^6.3.4"
},
"files": [
"dist"
],
"module": "./dist/es/index.mjs",
"types": "./dist/cjs/index.d.ts"
"bunchee": "^6.3.4",
"publint": "^0.3.12"
}
}
3 changes: 2 additions & 1 deletion packages/eslint-config-turbo/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ const config = {
extends: ["plugin:turbo/recommended"],
};

module.exports = config;
// eslint-disable-next-line import/no-default-export -- ESLint convention is a default export
export default config;
Copy link
Contributor Author

@anthonyshew anthonyshew Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bunchee wasn't converting module.exports to export default for the ESM entrypoints. If I make it export default, it downlevels to CJS correctly.

Loading
Loading