这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(turbo): graceful shutdown on sighup #10764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

fix(turbo): graceful shutdown on sighup #10764

merged 1 commit into from
Aug 14, 2025

Conversation

@chris-olszewski
Copy link
Contributor

@chris-olszewski chris-olszewski commented Aug 14, 2025

Description

When trying to figure out why grouped logs don't get flushed on GitHub Actions timeouts I came across actions/runner#1309

Seems promising, since I have verified that SIGINT results in logs getting flushed, but SIGHUP wouldn't trigger a flush.

Testing Instructions

Send a SIGHUP to turbo and verify that everything gets shut down cleanly:

[130 olszewski@macbookpro] /tmp/grouped $ turbo_dev --skip-infer dev --log-order=grouped
turbo 2.5.6-canary.1

• Packages in scope: @repo/eslint-config, @repo/typescript-config, @repo/ui, docs, web
• Running dev in 5 packages
• Remote caching disabled
web:dev: cache bypass, force executing b1407803afdc4dc7
web:dev: 
web:dev: > web@0.1.0 dev /private/tmp/grouped/apps/web
web:dev: > next dev --turbopack --port 3000
web:dev: 
web:dev:    ▲ Next.js 15.4.2 (Turbopack)
web:dev:    - Local:        http://localhost:3000
web:dev:    - Network:      http://192.168.86.73:3000
web:dev: 
web:dev:  ✓ Starting...
web:dev:  ✓ Ready in 942ms
web:dev: 
docs:dev: cache bypass, force executing 9119eefc14447289
docs:dev: 
docs:dev: > docs@0.1.0 dev /private/tmp/grouped/apps/docs
docs:dev: > next dev --turbopack --port 3001
docs:dev: 
docs:dev:    ▲ Next.js 15.4.2 (Turbopack)
docs:dev:    - Local:        http://localhost:3001
docs:dev:    - Network:      http://192.168.86.73:3001
docs:dev: 
docs:dev:  ✓ Starting...
docs:dev:  ✓ Ready in 943ms
docs:dev: 
 ERROR  run failed: command  exited (1)

@chris-olszewski chris-olszewski requested a review from a team as a code owner August 14, 2025 19:14
@vercel
Copy link
Contributor

vercel bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
examples-basic-web ✅ Ready Preview Comment Aug 14, 2025 7:14pm
examples-designsystem-docs ✅ Ready Preview Comment Aug 14, 2025 7:14pm
examples-gatsby-web ✅ Ready Preview Comment Aug 14, 2025 7:14pm
examples-kitchensink-blog ✅ Ready Preview Comment Aug 14, 2025 7:14pm
examples-nonmonorepo ✅ Ready Preview Comment Aug 14, 2025 7:14pm
examples-svelte-web ✅ Ready Preview Comment Aug 14, 2025 7:14pm
examples-tailwind-web ✅ Ready Preview Comment Aug 14, 2025 7:14pm
examples-vite-web ✅ Ready Preview Comment Aug 14, 2025 7:14pm
turbo-site ✅ Ready Preview Comment Aug 14, 2025 7:14pm

@chris-olszewski chris-olszewski merged commit ddaed6e into main Aug 14, 2025
40 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/flush_logs_on_sigint branch August 14, 2025 19:46
@renovate renovate bot mentioned this pull request Aug 24, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chris-olszewski @anthonyshew