这是indexloc提供的服务,不要输入任何密码
Skip to content

Apply global ignore patterns for global deps #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Apr 19, 2022

Closes #720

Most of time is walking about node_modules who we should ignore.

@vercel
Copy link

vercel bot commented Apr 19, 2022

Someone is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@jaredpalmer
Copy link
Contributor

Woops. Good catch!

@jaredpalmer
Copy link
Contributor

@elado this may have been what was slowing you down fyi

@jaredpalmer jaredpalmer added the kind: bug Something isn't working label Apr 19, 2022
@kodiakhq kodiakhq bot merged commit ad82272 into vercel:main Apr 19, 2022
@elado
Copy link

elado commented Apr 20, 2022

@jaredpalmer it improved things (35s -> 22s) but still not perfect.
node_modules files are about 180k files
Entire repo is around 500k files

@jaredpalmer
Copy link
Contributor

We are going to fix globbing shortly and should be massive win

@Kingwl
Copy link
Contributor Author

Kingwl commented Apr 21, 2022

node_modules files are about 180k files
Entire repo is around 500k files

Wow......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global dependencies always cause tree walk
3 participants