feat: add GitHub Actions environment variable as default passthru #10740
Conversation
Allowing those variables to pass through by default would make using turborepo with GitHub Actions more seamless. For example, NPM relies on `GITHUB_ACTIONS` for automatic provenance detection. (see https://github.com/npm/cli/blob/5d82d0b4a4bd1424031fb68b4df740c1bbe5b172/lib/utils/oidc.js#L11) By obfuscating the variable, it can be pretty confusing for users of both turborepo and npm as to why the provenance generation stopped working (don't ask me how I know).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@louis-bompart is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
A bit more esoteric but related to the same initial problem (npm publish with provenance fails if executed through turborepo), I think it might be good to add |
https://coveord.atlassian.net/browse/KIT-4720 and + some for Quantic, just playin' safe. Fix-it-twice maybe in vercel/turborepo#10740
https://coveord.atlassian.net/browse/KIT-4720 and + some for Quantic, just playin' safe. Fix-it-twice maybe in vercel/turborepo#10740
https://coveord.atlassian.net/browse/KIT-4720 and + some for Quantic, just playin' safe. Fix-it-twice maybe in vercel/turborepo#10740
|
@anthonyshew: That would be amazing if we could get this merged. I believe this is a blocker for adoption, or at least, a friction, as most nice CI features aren't working by default when using Turborepo because the |
Description
Allowing those variables to pass through by default would make using turborepo with GitHub Actions more seamless.
For example, NPM relies on
GITHUB_ACTIONSfor automatic provenance detection. (see https://github.com/npm/cli/blob/5d82d0b4a4bd1424031fb68b4df740c1bbe5b172/lib/utils/oidc.js#L11) By obfuscating the variable, it can be pretty confusing for users of both turborepo and npm as to why the provenance generation stopped working (don't ask me how I know).Testing Instructions
(I'll be honest, I did not test it, but essentially follow the footstep of #9235, just with some GitHub sprinkles on top.)