这是indexloc提供的服务,不要输入任何密码
Skip to content

chore(turbo_json): lift $TURBO_DEFAULT$ handling to turbo.json resolution #10709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 23, 2025

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Jul 23, 2025

Description

This PR moves the handling of $TURBO_DEFAULT$ to be the responsibility of turbo.json resolution.

Previously it was handled by our SCM module which should only be focused on SCM operations, not magical strings from Turborepo.

The changes to the daemon only affect the daemon input hashing logic which is currently disabled.

Reviewing each commit independently is suggested.

Testing Instructions

Added unit tests and existing tests.

Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 2:50pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 2:50pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 2:50pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 2:50pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 2:50pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 2:50pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 2:50pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 2:50pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 2:50pm

@chris-olszewski chris-olszewski changed the title chore(turbo_json): lift $TURBO_DEFAULT$ handling to turbo.json parse time chore(turbo_json): lift $TURBO_DEFAULT$ handling to turbo.json resolution Jul 23, 2025
@chris-olszewski chris-olszewski marked this pull request as ready for review July 23, 2025 14:44
@chris-olszewski chris-olszewski requested a review from a team as a code owner July 23, 2025 14:44
@chris-olszewski chris-olszewski enabled auto-merge (squash) July 23, 2025 15:01
@chris-olszewski chris-olszewski merged commit a795311 into main Jul 23, 2025
40 checks passed
@chris-olszewski chris-olszewski deleted the chrisolszewski/flow-4087-rework-turbo_default branch July 23, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants