fix: correctly read execution args from watch command #10381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@kade-robertson is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Closed
1 task
chris-olszewski
approved these changes
Apr 25, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up fix to: #10236
As it turns out, this change presented a regression in how the
--concurrencyflag behaves in watch mode. Previously, since this flag was read from theexecution_argsdirectly, it worked as expected. After switching it to read fromconfig, it no longer worked inwatchmode, asArgswould only extract correctly from theRuncommand.This change lets the
Args::execution_args()getter return the execution args from the watch command that has been run, if present. This is a pretty significant change, as previously none of the run mode execution args would be respected in watch mode. I'm not totally confident this is desired.The alternative is to bring back the special case for
concurrency, and try to read from execution_args directly when parsing it, and falling back toconfigotherwise.Testing Instructions
mainandpnpm build:turbo./path/to/turbo watch <some-cmd>in a repository where more than 10 tasks (the default) are persistent--concurrency=<task-count>does not override this setting