这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(dry): do not perform runtime validations on dry runs #10375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

fix(dry): do not perform runtime validations on dry runs #10375

merged 1 commit into from
Apr 24, 2025

Conversation

chris-olszewski
Copy link
Member

Description

I was poking around and hit a case where I couldn't use dry run if it included interactive tasks or too many persistent tasks for the concurrency.

These checks don't make sense for --graph or --dry since we're not actually executing the graph.

Testing Instructions

Added unit tests making sure that these checks are skipped.

Quick manual test:

[0 olszewski@macbookpro] $ turbo run dev --dry=json > /dev/null                
turbo 2.5.1-canary.1

  x Invalid task configuration
  |->   x You have 19 persistent tasks but `turbo` is configured for concurrency of 10. Set --concurrency to at least 20
  `->   x Cannot run interactive task "vercel-ship#dev" without Terminal UI. Set `"ui": true` in `turbo.json`, use the `--ui=tui` flag, or set `TURBO_UI=true` as
        | an environment variable.

[1 olszewski@macbookpro] $ turbo_dev --skip-infer dev --dry=json > /dev/null
turbo 2.5.1

[0 olszewski@macbookpro] $

@chris-olszewski chris-olszewski requested a review from a team as a code owner April 23, 2025 23:59
@vercel Vercel
Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:59pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:59pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:59pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:59pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:59pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:59pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:59pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:59pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:59pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:59pm

@chris-olszewski chris-olszewski merged commit 7f601ad into main Apr 24, 2025
38 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/dry-run-fixes branch April 24, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-olszewski @anthonyshew