feat(sidebar): improve folder link accessibility and UX #10349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@0xmuon is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
anthonyshew
approved these changes
Apr 17, 2025
Contributor
anthonyshew
left a comment
There was a problem hiding this comment.
This feels great! Thank you so much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refering the Discussion: #10328This PR improves the accessibility and user experience of the sidebar folder links by separating the navigation and toggle functionality into distinct interactive elements.
Key Changes:
aria-labelattributes for screen readers to indicate expand/collapse actionsTesting Instructions
This is what it was earlier:
https://drive.google.com/file/d/1-XLu9N_nAoksvfLQQlQQndniZFstABaM/view?usp=sharing
And this is how it looks now:
https://drive.google.com/file/d/1YOqaRRn6L-cFq2cgZH5Lg7u5HSx-d6A9/view?usp=sharing
Basic Functionality
Accessibility Testing
Edge Cases