fix(@turbo/repository): no longer require packageManager to detect npm #10314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
added a commit
that referenced
this pull request
Apr 14, 2025
### Description Bump version so I can release #10314 ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we had detected package manager, but wouldn't inform the package graph builder of our findings. This would later cause an error since the package graph builder wasn't configured to support detecting the package manager.
We now pass the initially discovered package manager in so we don't need to detect it.
This will still fail in cases of
pnpmandyarnif those binaries are not installed since we cannot determine which version of the package manager the user wants to use.Testing Instructions
Added new npm monorepo test fixture that is missing
packageManagerand a test that usesaffectedPackagesagainst it.