fix(codemod): check for pipeline key before using it #10295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
chris-olszewski
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After users successfully execute codemods for v1, their package manager installation at the end can fail, as seen in #8495. This means that the
pipelinekey would disappear, but theturboin the repository might be stuck at v1 still.If they try to run the codemods again, the codemod will try to execute codemods for v1 again, since that's what will be found in package.json. At this point, it will error, when it can't find the
pipelinekey.This PR introduces a guard that we can use to early exit if the
pipelinekey doesn't exist.Testing Instructions
I'm reproducing #8495 with these steps:
npx create-turbo@latestturboin package.json down to1.0.0.With the changes in this PR, the codemods are effectively skipped, and we make it past them succesfully.