这是indexloc提供的服务,不要输入任何密码
Skip to content

fix(docs): fix SVG attribute casing to remove React warnings #10297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

ohprettyhak
Copy link
Contributor

@ohprettyhak ohprettyhak commented Apr 6, 2025

Description

Screenshot 2025-04-06 at 14 59 33 Screenshot 2025-04-06 at 14 59 46
`turborepo-wordmark.tsx` `magnifying-glass.tsx`

This PR fixes React warnings caused by incorrectly cased SVG attribute names in turborepo-wordmark.tsx and magnifying-glass.tsx.

The root cause is the use of non-camelCase attribute names in SVG elements, which is not compliant with React's expected syntax.

To resolve this, the affected SVG attributes have been updated to use camelCase, eliminating the warnings during next dev.

Testing Instructions

Clone the PR and run the project with next dev, or review the updated code to verify that the SVG attribute casing issues have been resolved.

@ohprettyhak ohprettyhak requested review from anthonyshew and a team as code owners April 6, 2025 06:11
@turbo-orchestrator turbo-orchestrator bot added area: site needs: triage New issues get this label. Remove it after triage labels Apr 6, 2025
Copy link

vercel bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 2:32am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 2:32am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 2:32am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 2:32am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 2:32am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 2:32am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 2:32am

Copy link

vercel bot commented Apr 6, 2025

@ohprettyhak is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ohprettyhak
Copy link
Contributor Author

Closed as a duplicate of #10294.

@anthonyshew
Copy link
Contributor

Thank you for the PR! Looks like we both noticed it. 😁 I'm happy to close mine and use yours, if you'd like!

@ohprettyhak
Copy link
Contributor Author

@anthonyshew Hello! I’d really appreciate it if you could do that.

@anthonyshew
Copy link
Contributor

Certainly! Re-open when ready.

@ohprettyhak ohprettyhak restored the fix/docs/react-svg-error branch April 6, 2025 14:30
@ohprettyhak ohprettyhak reopened this Apr 6, 2025
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthonyshew anthonyshew merged commit 77df7d2 into vercel:main Apr 7, 2025
30 of 33 checks passed
@ohprettyhak ohprettyhak deleted the fix/docs/react-svg-error branch April 8, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: site needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants