-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(bun): deserialize correctly and use optionalPeers #10219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chris-olszewski
merged 3 commits into
vercel:main
from
camero2734:bun-prune-missing-dependencies
Mar 31, 2025
Merged
fix(bun): deserialize correctly and use optionalPeers #10219
chris-olszewski
merged 3 commits into
vercel:main
from
camero2734:bun-prune-missing-dependencies
Mar 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g for optionalPeers
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@camero2734 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
chris-olszewski
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great find! Thank you for the fix.
This was referenced Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9058 and #7456 (again)
When I tested my previous PR (#10175) on another repo, I discovered an issue with a missing dep in the pruned lockfile
To reproduce this in the
with-yarn
example repo:cd apps/web && bun install dd-trace
and
cd apps/docs && bun install @opentelemtry/api
Then run prune for
web
and trybun install --frozen-lockfile
and you'll get this:Issue 1 -- Deserialization casing
The underlying error is rather straightforward -- it was deserializing most dependencies (

peerDependencies
,devDependencies
,optionalDependencies
) toother
😄This is because it just needed
#[serde(rename_all = "camelCase")]
since the rust names are snake case. This is whydependencies
happened to work -- it's the same in snake and camel case.By virtue of being in
other
, all non-dependencies
packages were effectively ignored during the pruning process, and don't always end up in the resulting lockfile.Issue 2 -- optionalPeers
After fixing that, I also stumbled upon another issue:
This is because we weren't accounting for the
optionalPeers
property.next
doesn't actually require you have@playwright/test
, it's an optional peer. I fixed this as well.