这是indexloc提供的服务,不要输入任何密码
Skip to content

ci: use git commands instead of a package #10218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 31, 2025
Merged

ci: use git commands instead of a package #10218

merged 9 commits into from
Mar 31, 2025

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Mar 21, 2025

Description

The package we were using before wasn't serving us well, so choosing to drop down an abstraction level here.

This PR uses bash and git to find path changes.

Testing Instructions

Proofs:

  • No changes (except the workflow file, as expected): e026cee
  • A change in docs: 0fcdbab
  • A change in basic example: 0069c34
  • A change in rest: 9622226 (A little difficult to see since "No changes" is the same, but I edited a README in crates)
  • A change in both rest and an example: 985ce6a
  • A change in both rest and docs: 5291f41

@anthonyshew anthonyshew requested a review from a team as a code owner March 21, 2025 19:51
Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 9:04pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 9:04pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 9:04pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 9:04pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 9:04pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 9:04pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 9:04pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 9:04pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 9:04pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 9:04pm

# Check each path pattern with a more readable syntax
echo "Checking path patterns..."

check_paths "docs" "docs/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be hooked up to something? I'm not seeing any triggers on the example runs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs checks happen in https://github.com/vercel/turborepo/blob/main/.github/workflows/docs.yml, which is confusing. It might have been that I intended to run those in this file, so they could become blocking when they should, but didn't wire it up. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/vercel/turborepo/actions/runs/14000711838/job/39206316471?pr=10218 is the smoking gun for me that these changes are at least on the right track.

@anthonyshew
Copy link
Contributor Author

Merging now as I'm about to do some stuff for examples. Will be keeping an eye out and have notified the team to make sure everything they expect is running.

@anthonyshew anthonyshew merged commit 57f40b2 into main Mar 31, 2025
35 checks passed
@anthonyshew anthonyshew deleted the shew/f611f branch March 31, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants