-
Notifications
You must be signed in to change notification settings - Fork 2k
ci: use git commands instead of a package #10218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Check each path pattern with a more readable syntax | ||
echo "Checking path patterns..." | ||
|
||
check_paths "docs" "docs/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be hooked up to something? I'm not seeing any triggers on the example runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs checks happen in https://github.com/vercel/turborepo/blob/main/.github/workflows/docs.yml, which is confusing. It might have been that I intended to run those in this file, so they could become blocking when they should, but didn't wire it up. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/vercel/turborepo/actions/runs/14000711838/job/39206316471?pr=10218 is the smoking gun for me that these changes are at least on the right track.
Merging now as I'm about to do some stuff for examples. Will be keeping an eye out and have notified the team to make sure everything they expect is running. |
Description
The package we were using before wasn't serving us well, so choosing to drop down an abstraction level here.
This PR uses bash and git to find path changes.
Testing Instructions
Proofs:
basic
example: 0069c34rest
: 9622226 (A little difficult to see since "No changes" is the same, but I edited a README in crates)rest
and an example: 985ce6arest
and docs: 5291f41