-
Notifications
You must be signed in to change notification settings - Fork 2.1k
chore(boundaries): allow packages to import themselves #10202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments:
turborepo-tests/integration/tests/command-boundaries.t (line 13):
The test file was not updated after the fixture was modified to include a self-import, causing hardcoded git object hashes and expected diff output to be stale and incorrect.
View Details
📝 Patch Details
diff --git a/turborepo-tests/integration/tests/command-boundaries.t b/turborepo-tests/integration/tests/command-boundaries.t
index a93dcbc13..1934e6c2f 100644
--- a/turborepo-tests/integration/tests/command-boundaries.t
+++ b/turborepo-tests/integration/tests/command-boundaries.t
@@ -10,7 +10,7 @@ Ignore all errors
$ git diff
diff --git a/apps/my-app/index.ts b/apps/my-app/index.ts
- index 6baec29..d4c7af6 100644
+ index 41f5d9c..81fb062 100644
--- a/apps/my-app/index.ts
+++ b/apps/my-app/index.ts
@@ -1,9 +1,13 @@
Analysis
Stale git object hashes in command-boundaries.t test after fixture modification
What fails: Test file turborepo-tests/integration/tests/command-boundaries.t on line 13 contains hardcoded git object hash 6baec29 that doesn't match the current fixture file turborepo-tests/integration/fixtures/boundaries/apps/my-app/index.ts
How to reproduce:
cd turborepo-tests/integration/fixtures/boundaries
git hash-object apps/my-app/index.ts
# Returns: 41f5d9c2d90976132b9eb36486423526d06d86ce
# Test expects: 6baec29605d51c498e0f4c0880e8cb48d155bb19Result: Test expects git hash 6baec29 (old fixture without self-import on lines 26-27) but fixture now produces hash 41f5d9c. Similarly, the expected hash after applying @boundaries-ignore comments is d4c7af6 but should be 81fb062.
Expected: Test should use git hashes that match current fixture content: 41f5d9c (before) and 81fb062 (after adding ignore comments).
Root cause: Fixture was modified to add self-import import { walkThePlank } from "my-app"; on lines 26-27 (per comment "Allow importing own package"), but test's hardcoded git hashes weren't updated to reflect the new fixture content.
Description
Packages can import themselves for testing purposes.
Testing Instructions
Added a self import to fixture.