这是indexloc提供的服务,不要输入任何密码
Skip to content

chore(frameworks): move framework logic to new crate #10198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

chris-olszewski
Copy link
Member

Description

Did this prefactor for a feature that we didn't end up needing, but figured it still was a bit of cleanup.

  • Move this logic out of turborepo-lib
  • Hide framework slug behind a newtype to allow for safe framework lookup by slug

Testing Instructions

👀 + rustc

@chris-olszewski chris-olszewski requested a review from a team as a code owner March 19, 2025 20:16
Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:33pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:33pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:33pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:33pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:33pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:33pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:33pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:33pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:33pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 8:33pm

@chris-olszewski chris-olszewski merged commit 12e1c9f into main Mar 20, 2025
38 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/feat_framework_pass_through branch March 20, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants