-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(turbo json): make with
public
#10191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chris-olszewski
merged 8 commits into
main
from
chrisolszewski/turbo-4375-sibling-tasks
Mar 18, 2025
Merged
feat(turbo json): make with
public
#10191
chris-olszewski
merged 8 commits into
main
from
chrisolszewski/turbo-4375-sibling-tasks
Mar 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
50f5f6a
to
753e0de
Compare
anthonyshew
reviewed
Mar 18, 2025
anthonyshew
reviewed
Mar 18, 2025
anthonyshew
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor docs/error message from me. Exciting!
Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make public the feature added in #9504 that allows for pulling in extra tasks into the graph without a
dependsOn
relationship.Renamed to
with
as it is better thansibling
since that indicates a shared parent, which isn't required.Testing Instructions
Added quick unit test for parsing and error validation.
Basic test:
Error message for trying to use
^