这是indexloc提供的服务,不要输入任何密码
Skip to content

Improve WalkMode usage #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2022
Merged

Improve WalkMode usage #1018

merged 5 commits into from
Apr 7, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Apr 7, 2022

  • Provide an error callback so that we can recover from permissions errors (skip the offending item)
  • Change workspace ignore patterns to ignore the directories themselves, rather than directories/files inside the ignored files
  • Document our current symlink behavior in directory walks

Fixes #997

@vercel
Copy link

vercel bot commented Apr 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Updated Deployment Preview
turbo-site ✅ Deployed Apr 7, 2022 at 9:19PM (UTC) View on Vercel View Preview

@gsoltis gsoltis changed the title Improve globby usage Improve FileWalk usage Apr 7, 2022
@gsoltis gsoltis changed the title Improve FileWalk usage Improve WalkMode usage Apr 7, 2022
@kodiakhq kodiakhq bot merged commit 5b9aa89 into main Apr 7, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/handle_perms_error branch April 7, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Turbo should not die on permissions errors, and should log a warning for permissions errors inside workspaces
2 participants