这是indexloc提供的服务,不要输入任何密码
Skip to content

chore: dogfood $TURBO_ROOT$ #10168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Conversation

chris-olszewski
Copy link
Member

Description

Dogfood the new $TURBO_ROOT$ feature as there were a few places we were depending on ../

Testing Instructions

CI

@chris-olszewski chris-olszewski requested a review from a team as a code owner March 14, 2025 17:50
Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 6:32pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 6:32pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 6:32pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 6:32pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 6:32pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 6:32pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 6:32pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 6:32pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 6:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
turbo-site ⬜️ Skipped (Inspect) Mar 14, 2025 6:32pm

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beauuutiful.

@chris-olszewski
Copy link
Member Author

Failures seem unrelated #10169

Will not force through, but just confirming this isn't some bug in $TURBO_ROOT$

@chris-olszewski chris-olszewski changed the base branch from main to olszewski/fix_eslint_config_build March 14, 2025 18:18
@chris-olszewski chris-olszewski changed the base branch from olszewski/fix_eslint_config_build to main March 14, 2025 18:19
chris-olszewski added a commit that referenced this pull request Mar 14, 2025
### Description

See failure on #10168
```
Error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (npm/cli#4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.
```

[source](https://github.com/vercel/turborepo/actions/runs/13862424976/job/38794202787#step:6:461)

Rollup distributes binaries using the same strategy we do so skipping
installing optional dependencies skips installing the actual binary.

### Testing Instructions

Will open PR against this one that triggers `eslint-config-turbo#build`:
https://github.com/vercel/turborepo/actions/runs/13862902922?pr=10171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants