feat(boundaries): package name as tag punning #10151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
a3f8608 to
0be73a8
Compare
anthonyshew
approved these changes
Mar 13, 2025
chris-olszewski
approved these changes
Mar 13, 2025
Comment on lines
+116
to
+121
| impl Spanned<String> { | ||
| pub fn as_str(&self) -> &str { | ||
| self.value.as_str() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think this is needed since Spanned already implements deref?
Suggested change
| impl Spanned<String> { | |
| pub fn as_str(&self) -> &str { | |
| self.value.as_str() | |
| } | |
| } |
There was a problem hiding this comment.
Does Rust chain derefs? When I did as_deref for Option<Spanned<String>>, I got Option<&String> and not Option<&str>?
There was a problem hiding this comment.
I think you need to specify the deref type sometimes to help out. I know I've needed to do that when working with Cow sometimes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows a package name to be used as a tag (tag punning). We're adding this feature to help users define an explicit set of packages that their package can be imported by. Combined with the ability to define package rules in a package
turbo.json(next PR after this, coming soon), and code owner restrictions, this will permit package owners to control who can import their package.Testing Instructions
Added test in
boundaries_tagsfixture