fix(bun): properly handle bun lockfile keys #10137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6ac666f to
4946338
Compare
This was referenced Mar 12, 2025
d1da4da to
6c79877
Compare
anthonyshew
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were not properly handling recursing when traversing the lockfile. Resolving a package would give a
package@versionkey instead of the key into thepackagesarray. Ourall_dependenciesimplementation assumed that we were given the key intopackages.This is a little odd as the keys can have different "paths" (keys to the packages object) that map to identical entries. This PR adds a check to verify that the entries are in fact the same package by comparing checksums.
Testing Instructions
Fixed unit tests and added one with mismatched checksums.
create-turbousing bun should no longer displayWARNING Unable to calculate transitive closures: No lockfile entry found for '@types/react@19.0.10'