这是indexloc提供的服务,不要输入任何密码
Skip to content

Add v1.2 blog post #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 7, 2022
Merged

Add v1.2 blog post #1012

merged 24 commits into from
Apr 7, 2022

Conversation

jaredpalmer
Copy link
Contributor

@jaredpalmer jaredpalmer commented Apr 6, 2022

  • Open Graph Image
  • Dry Run Graphic
  • Linkified stats
  • Proofread

@vercel
Copy link

vercel bot commented Apr 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Updated Deployment Preview
turbo-site ✅ Deployed Apr 7, 2022 at 8:51PM (UTC) View on Vercel View Preview

@jaredpalmer jaredpalmer requested review from leerob and acviana April 6, 2022 23:22
nathanhammond
nathanhammond previously approved these changes Apr 7, 2022
Copy link
Contributor

@nathanhammond nathanhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A whole bunch of optional tiny comments, no material issues.

@weyert
Copy link
Contributor

weyert commented Apr 7, 2022

How would you rewrite this command to use --filter to avoid the deprecated arguments?
turbo run build --cache-dir=.turbo-cache --include-dependencies --no-deps or
turbo run build --cache-dir=.turbo-cache --include-dependencies

Maybe worth it to add these to the docs or in the blog post?

Co-authored-by: Nathan Hammond <github.com@nathanhammond.com>
Co-authored-by: Nathan Hammond <github.com@nathanhammond.com>
@gsoltis
Copy link
Contributor

gsoltis commented Apr 7, 2022

@weyert In your examples, there is nothing scoping down the selection, build will run on every package. Did you mean to include a --scope?

jaredpalmer and others added 2 commits April 7, 2022 10:10
Co-authored-by: Nathan Hammond <github.com@nathanhammond.com>
Co-authored-by: Nathan Hammond <github.com@nathanhammond.com>
Co-authored-by: Greg Soltis <greg.soltis@vercel.com>
@thebanjomatic
Copy link
Contributor

thebanjomatic commented Apr 7, 2022

The 1.1 blog mentions partial support for yarn 2+ (nodeLinker: node-modules only), is it worth adding a note about yarn 2+ with the PnP linker now being supported for the run command, but that prune is still not fully supported?

Co-authored-by: Becca Z <23545426+becca@users.noreply.github.com>
Co-authored-by: Becca Z <23545426+becca@users.noreply.github.com>
@acviana
Copy link

acviana commented Apr 7, 2022

@jaredpalmer Is there something data-specific you were hoping I could contribute to this MR or did you just need another set of eyes?

@jaredpalmer
Copy link
Contributor Author

jaredpalmer commented Apr 7, 2022

@acviana No, I think you were erroneously asked for a review, sorry about that

Co-authored-by: Becca Z <23545426+becca@users.noreply.github.com>
@jaredpalmer jaredpalmer changed the title WIP: Add v1.2 blog post Add v1.2 blog post Apr 7, 2022
@jaredpalmer jaredpalmer merged commit b733a69 into main Apr 7, 2022
@jaredpalmer jaredpalmer deleted the jp/blog-post-1.2 branch April 7, 2022 20:51
@acviana acviana removed their request for review April 7, 2022 21:07
@weyert
Copy link
Contributor

weyert commented Apr 8, 2022

@weyert In your examples, there is nothing scoping down the selection, build will run on every package. Did you mean to include a --scope?

@gsoltis Yes, but is --include-dependencies not deprecated now?

The documentation says:

--include-dependencies is deprecated in 1.2.x. Please use --filter instead.

So my question how can I use --include-dependencies when I don't want to filter a package when I can't use the deprecated --include-dependencies? As the default is false` for this flag

@gsoltis
Copy link
Contributor

gsoltis commented Apr 8, 2022

@weyert --include-dependencies is indeed deprecated. You can achieve the same behavior in --filter with --filter=my-pkg...

Maybe the source of confusion is that, without supplying --filter (or --scope, or --since), turbo will run against every package. In both of your examples, you are running build against every package, since you are not providing --filter, --scope, or --since. Any dependencies that would be included with --include-dependencies are already included.

My expectation is that there are very few situations where you will need to include dependencies, either via the deprecated flag or even via a filter, because usually your pipeline takes care of defining the dependencies for you. So with a pipeline where build depends on ^build, turbo run build --filter=my-app will build my-app and all of its dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants