chore: update to Rust 2024 edition #10114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ognevny is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
NicholasLYang
approved these changes
Mar 6, 2025
|
wait a bit, there are test failures... edit: fixed, I should have done better check locally, sorry |
chris-olszewski
pushed a commit
that referenced
this pull request
Mar 31, 2025
… edition (#10260) ### Description in #10114 I tried to update turborepo-filewatch, but it failed due to functions being automatically marked as unsafe when using `unsafe extern "C"`. Rust provides a `safe` keyword to fall to previous behavior. turborepo-process was added recently but it used edition 2021 <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions CI. I don't have an Apple machine :( <!-- Give a quick description of steps to test your changes. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update to 2024 edition:
use<>syntax required in several places; exclude turborepo-filewatch because I don't have macos machine to properly address failuresgenis now a keyword, user#gento fix compile error: https://doc.rust-lang.org/edition-guide/rust-2024/gen-keyword.htmlTesting Instructions
CI