feat(boundaries): implicit dependencies #10117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
approved these changes
Mar 7, 2025
Contributor
chris-olszewski
left a comment
There was a problem hiding this comment.
My only concert is the possibility of using implicitDependencies to cover up a bad package graph.
| pub struct RootBoundariesConfig { | ||
| pub struct BoundariesConfig { | ||
| pub tags: Option<Spanned<RulesMap>>, | ||
| pub implicit_dependencies: Option<Spanned<Vec<Spanned<String>>>>, |
Contributor
There was a problem hiding this comment.
Just noticed in the snapshots we're serializing "implicitDependencies": null, maybe #[serde(skip_serializing_if = "Option::is_none")]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to allowlist implicit dependencies for boundaries. This is useful in cases where testing libraries or frameworks can inject globals such as
server-onlyCan be reviewed commit by commit
Testing Instructions
Added test to boundaries. Note the snapshots do not change since no errors are produced. To verify stuff is working as intended, try removing the
implicitDependencieskey and note that an error is produced.