这是indexloc提供的服务,不要输入任何密码
Skip to content

fix: adds callout for installation instructions for PNPM #10100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

Tigatok
Copy link
Contributor

@Tigatok Tigatok commented Mar 5, 2025

Refs: 10099

Description

Adds callout for installation instructions in documentation page.

@Tigatok Tigatok requested review from anthonyshew and a team as code owners March 5, 2025 17:54
@Tigatok Tigatok requested a review from chris-olszewski March 5, 2025 17:54
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage labels Mar 5, 2025
Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:41pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:41pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:41pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:41pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:41pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:41pm

Copy link

vercel bot commented Mar 5, 2025

@Tigatok is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good addition. Do you think you could move this into the tab for pnpm? Users of other package managers wouldn't need to see this information, so it would be great to localize. You won't need to have it be in a in there, as well.

@Tigatok
Copy link
Contributor Author

Tigatok commented Mar 5, 2025

Oh, good addition. Do you think you could move this into the tab for pnpm? Users of other package managers wouldn't need to see this information, so it would be great to localize. You won't need to have it be in a in there, as well.

Yep, you bet. I wasn't exactly sure myself so just wanted to get something up so I could get feedback like this :). Is there a proper way I can run the docs locally? I pushed the change but I am not sure if there is a quick way of me validating locally so I can avoid murdering the pipeline.

@anthonyshew
Copy link
Contributor

There isn't at this time, unfortunately. I have to check by hand. But here it is below, looking good!
CleanShot 2025-03-05 at 13 42 40

@anthonyshew anthonyshew enabled auto-merge (squash) March 5, 2025 20:44
@anthonyshew anthonyshew merged commit bc2ba73 into vercel:main Mar 5, 2025
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants